Author: timbo
Date: Mon Apr 16 02:57:04 2007
New Revision: 9417
Modified:
dbi/trunk/Changes
dbi/trunk/DBI.pm
dbi/trunk/META.yml
Log:
Always delete Password from connect attr.
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Mon Apr 16 02:57:04 2007
@@ -55,7 +55,6 @@
Changed tests to work with other DBMs thanks to ZMAN.
Many assorted Gofer related bug fixes, enhancements and docs.
- Added support for install_methods to DBD::Gofer.
Added goferperf.pl utility (doesn't get installed).
Added support for DBI Profile Path to contain refs to scalars
which will be de-ref'd for each profile sample.
Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm (original)
+++ dbi/trunk/DBI.pm Mon Apr 16 02:57:04 2007
@@ -612,8 +612,9 @@
or die "panic: $class->install_driver($driver) failed";
# attributes in DSN take precedence over \%attr connect parameter
- $user = $attr->{Username} if defined $attr->{Username};
- $pass = delete $attr->{Password} if defined $attr->{Password};
+ $user = $attr->{Username} if defined $attr->{Username};
+ $pass = $attr->{Password} if defined $attr->{Password};
+ delete $attr->{Password}; # always delete Password as closure stores it
securely
if ( !(defined $user && defined $pass) ) {
($user, $pass) = $drh->default_user($user, $pass, $attr);
}
Modified: dbi/trunk/META.yml
==============================================================================
--- dbi/trunk/META.yml (original)
+++ dbi/trunk/META.yml Mon Apr 16 02:57:04 2007
@@ -5,7 +5,8 @@
version_from: DBI.pm
installdirs: site
requires:
- File::Spec: 1
+ File::Spec: 0
+ Scalar::Util: 0
Storable: 1
Test::Simple: 0.4
