Author: timbo
Date: Thu Aug 23 04:33:10 2007
New Revision: 9872

Modified:
   dbi/trunk/DBI.pm
   dbi/trunk/lib/DBD/Proxy.pm

Log:
Fix proxy_rows when 0
Tweak docs re mailing list and cpanforum


Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm    (original)
+++ dbi/trunk/DBI.pm    Thu Aug 23 04:33:10 2007
@@ -83,8 +83,12 @@
 =head2 GETTING HELP
 
 If you have questions about DBI, or DBD driver modules, you can get
-help from the I<[EMAIL PROTECTED]> mailing list.  You can get help
-on subscribing and using the list by emailing I<[EMAIL PROTECTED]>.
+help from the I<[EMAIL PROTECTED]> mailing list.  You don't have to subscribe
+to the list in order to post, though I'd recommend it. You can get help on
+subscribing and using the list by emailing I<[EMAIL PROTECTED]>.
+
+I don't recommend the DBI cpanform (at http://www.cpanforum.com/dist/DBI)
+because relatively few people read it compared with [EMAIL PROTECTED]
 
 To help you make the best use of the dbi-users mailing list,
 and any other lists or forums you may use, I I<strongly>

Modified: dbi/trunk/lib/DBD/Proxy.pm
==============================================================================
--- dbi/trunk/lib/DBD/Proxy.pm  (original)
+++ dbi/trunk/lib/DBD/Proxy.pm  Thu Aug 23 04:33:10 2007
@@ -593,8 +593,7 @@
 
     my $data = $sth->{'proxy_data'};
 
-    defined($sth->{'proxy_rows'}) ||
-      ( $sth->{'proxy_rows'} = 0 );
+    $sth->{'proxy_rows'} = 0 unless defined $sth->{'proxy_rows'};
 
     if(!$data || [EMAIL PROTECTED]) {
        return undef unless $sth->SUPER::FETCH('Active');
@@ -625,8 +624,8 @@
 *fetchrow_arrayref = \&fetch;
 
 sub rows ($) {
-    my($sth) = @_;
-    $sth->{'proxy_rows'} || -1;
+    my $rows = shift->{'proxy_rows'};
+    return (defined $rows) ? $rows : -1;
 }
 
 sub finish ($) {

Reply via email to