Author: timbo
Date: Mon Apr 28 14:51:00 2008
New Revision: 11149

Modified:
   dbi/trunk/Changes
   dbi/trunk/DBI.xs

Log:
Fixed lean in neat() for some kinds of values thanks to Rudolf Lippan.


Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes   (original)
+++ dbi/trunk/Changes   Mon Apr 28 14:51:00 2008
@@ -32,6 +32,7 @@
 Add attr-passthru to prepare()? ie for gofer cache control & ReadOnly
 Terminology for client and server ends
 Document user/passwd issues at the various levels of the gofer stack
+    Remove "Password" from connect attr if the same as $password arg
 Policy's from pod
 Policy for dbh attr FETCH (ie example_driver_path)
     or piggyback on skip_connect_check
@@ -49,6 +50,7 @@
     methods that get embedded into compiled drivers to use the
     inner sth handle when passed a $sth instead of an sql string.
     Drivers will need to be recompiled to pick up this change.
+  Fixed lean in neat() for some kinds of values thanks to Rudolf Lippan.
 
   Increased timeout on tests to accomodate very slow systems.
   Removed the beeps "\a" from Makefile.PL warnings.

Modified: dbi/trunk/DBI.xs
==============================================================================
--- dbi/trunk/DBI.xs    (original)
+++ dbi/trunk/DBI.xs    Mon Apr 28 14:51:00 2008
@@ -378,7 +378,7 @@
        else nsv = newSVpvf("%"NVgf, SvNVX(sv));
        if (infosv)
            sv_catsv(nsv, infosv);
-       return SvPVX(nsv);
+       return SvPVX(sv_2mortal(nsv));
     }
 
     nsv = sv_newmortal();
@@ -2962,7 +2962,7 @@
         /* we don't use ENTER,SAVETMPS & FREETMPS,LEAVE because we may need 
mortal
          * results to live long enough to be returned to our caller
          */
-        /* we want to localize $_ for the callback but can't just to that alone
+        /* we want to localize $_ for the callback but can't just do that alone
          * because we're not using SAVETMPS & FREETMPS, so we have to get 
sneaky.
          * We still localize, so we're safe from the callback dieing,
          * but after the callback we manually restore the original $_.

Reply via email to