Author: timbo
Date: Sat Aug 1 12:34:49 2009
New Revision: 13151
Modified:
dbi/trunk/Changes
dbi/trunk/DBI.pm
dbi/trunk/DBI.xs
dbi/trunk/Driver.xst
dbi/trunk/README
Log:
Bumped required perl version to 5.8.1 (as announced in DBI 1.607)
Changed "Issuing rollback() due to DESTROY without explicit disconnect"
warning to not be issued if ReadOnly set for that dbh.
Avoid compiler warning.
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Sat Aug 1 12:34:49 2009
@@ -6,6 +6,12 @@
=cut
+=head2 Changes in DBI 1.611 (svn rXXX)
+
+ Changed "Issuing rollback() due to DESTROY without explicit disconnect"
+ warning to not be issued if ReadOnly set for that dbh.
+ Bumped required perl version to 5.8.1 (as announced in DBI 1.607)
+
=head2 Changes in DBI 1.609 (svn r12816) 8th June 2009
Fixes to DBD::File (H.Merijn Brand)
Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm (original)
+++ dbi/trunk/DBI.pm Sat Aug 1 12:34:49 2009
@@ -6,10 +6,10 @@
# See COPYRIGHT section in pod text below for usage and distribution rights.
#
-require 5.006_00;
+require 5.008_001;
BEGIN {
-$DBI::VERSION = "1.609"; # ==> ALSO update the version in the pod text below!
+$DBI::VERSION = "1.611"; # ==> ALSO update the version in the pod text below!
}
=head1 NAME
@@ -121,7 +121,7 @@
=head2 NOTES
-This is the DBI specification that corresponds to the DBI version 1.609
+This is the DBI specification that corresponds to the DBI version 1.611
($Revision$).
The DBI is evolving at a steady pace, so it's good to check that
Modified: dbi/trunk/DBI.xs
==============================================================================
--- dbi/trunk/DBI.xs (original)
+++ dbi/trunk/DBI.xs Sat Aug 1 12:34:49 2009
@@ -620,7 +620,7 @@
if ( DBIc_has(imp_xxh, DBIcf_HandleSetErr)
&& (hook_svp = hv_fetch((HV*)SvRV(h),"HandleSetErr",12,0))
&& hook_svp
- && ((SvGMAGICAL(*hook_svp) && mg_get(*hook_svp)), SvOK(*hook_svp))
+ && ((void)(SvGMAGICAL(*hook_svp) && mg_get(*hook_svp)),
SvOK(*hook_svp))
) {
dSP;
IV items;
Modified: dbi/trunk/Driver.xst
==============================================================================
--- dbi/trunk/Driver.xst (original)
+++ dbi/trunk/Driver.xst Sat Aug 1 12:34:49 2009
@@ -367,8 +367,9 @@
XXX Could add an attribute flag to indicate that the driver
doesn't have this problem. Patches welcome.
*/
- if (DBIc_WARN(imp_dbh)
+ if (DBIc_WARN(imp_dbh) /* only warn if likely to be useful...
*/
&& DBIc_is(imp_dbh, DBIcf_Executed) /* has not just called
commit/rollback */
+ && !DBIc_is(imp_dbh, DBIcf_ReadOnly) /* is not read only */
&& (!dirty || DBIc_DBISTATE(imp_dbh)->debug >= 3)
) {
warn("Issuing rollback() due to DESTROY without explicit
disconnect() of %s handle %s",
Modified: dbi/trunk/README
==============================================================================
--- dbi/trunk/README (original)
+++ dbi/trunk/README Sat Aug 1 12:34:49 2009
@@ -52,7 +52,7 @@
BEFORE BUILDING, TESTING AND INSTALLING this you will need to:
- Build, test and install Perl 5 (5.6 or later).
+ Build, test and install a recent version of Perl 5
It is very important to test it and actually install it!
(You can use "Configure -Dprefix=..." to build a private copy.)
