Author: timbo
Date: Tue Mar  2 10:11:17 2010
New Revision: 13832

Modified:
   dbi/trunk/Changes
   dbi/trunk/DBI.pm

Log:
Fixed selectcol_arrayref MaxRows attribute to count rows not values thanks to 
Vernon Lyon.
Tidied up Changes


Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes   (original)
+++ dbi/trunk/Changes   Tue Mar  2 10:11:17 2010
@@ -8,36 +8,36 @@
 
 =head2 Changes in DBI 1.611 (svn rXXX)
 
-  Document fetchrow_hashref() behaviour for functions,
-    aliases and duplicate names (H.Merijn Brand)
+  NOTE: minimum perl version is now 5.8.1 (as announced in DBI 1.607)
+
+  Fixed selectcol_arrayref MaxRows attribute to count rows not values
+    thanks to Vernon Lyon.
   Fixed DBI->trace(0, *STDERR); (H.Merijn Brand)
     which tried to open a file named "*main::STDERR" in perl-5.10.x
-  Corrected typos in Gopher documentation. Tipped by Jan Krynicky.
-
-  Bumped required perl version to 5.8.1 (as announced in DBI 1.607)
-
-http://perlmonks.org/?node_id=809590
 
-  Added f_lock support to DBD::File (H.Merijn Brand)
-XXX needs to be redone to convert ReadOnly to an internal flag:
   Changed "Issuing rollback() due to DESTROY without explicit disconnect"
     warning to not be issued if ReadOnly set for that dbh.
-  Updated dbipport.h to Devel::PPPort 3.19 (H.Merijn Brand)
-  Updated DBI::Profile and DBD::File docs to fix pod nits
-    thanks to Frank Wiegand.
 
+  Added f_lock support to DBD::File (H.Merijn Brand)
   Added ChildCallbacks => { ... } to Callbacks as a way to
     specify Callbacks for child handles.
     With tests and docs thanks to David E. Wheeler.
 XXX awaiting docs for ChildCallbacks from David.
-
   Added DBI::sql_type_cast($value, $type, $flags) to cast a string value
     to an SQL type. e.g. SQL_INTEGER effectively does $value += 0;
     Has other options plus an internal interface for drivers.
 
-  Added specification of type casting behaviour for bind_col()
+  Documentation changes:
+  Documented specification of type casting behaviour for bind_col()
     based on DBI::sql_type_cast() and two new bind_col attributes
     StrictlyTyped and DiscardString. Thanks to Martin Evans.
+  Document fetchrow_hashref() behaviour for functions,
+    aliases and duplicate names (H.Merijn Brand)
+  Updated DBI::Profile and DBD::File docs to fix pod nits
+    thanks to Frank Wiegand.
+  Corrected typos in Gopher documentation reported by Jan Krynicky.
+
+  Updated dbipport.h to Devel::PPPort 3.19 (H.Merijn Brand)
 
 =head2 Changes in DBI 1.609 (svn r12816) 8th June 2009
 

Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm    (original)
+++ dbi/trunk/DBI.pm    Tue Mar  2 10:11:17 2010
@@ -1655,7 +1655,7 @@
        }
        my @col;
        if (my $max = $attr->{MaxRows}) {
-           push @col, @values while @col<$max && $sth->fetch;
+           push @col, @values while 0 < $max-- && $sth->fetch;
        }
        else {
            push @col, @values while $sth->fetch;

Reply via email to