[svn:dbi] r14347 - dbi/trunk/lib/DBD

[REHSACK]

Author: REHSACK
Date: Sat Aug 28 04:07:38 2010
New Revision: 14347

Modified:
   dbi/trunk/lib/DBD/DBM.pm
   dbi/trunk/lib/DBD/File.pm

Log:
adding comments when $@ isn't proved sometimes


Modified: dbi/trunk/lib/DBD/DBM.pm
==============================================================================
--- dbi/trunk/lib/DBD/DBM.pm    (original)
+++ dbi/trunk/lib/DBD/DBM.pm    Sat Aug 28 04:07:38 2010
@@ -173,6 +173,8 @@
     my $dtype = $meta->{dbm_type};
     eval {
         $dver = $meta->{dbm_type}->VERSION();
+
+        # *) when we're still alive here, everthing went ok - no need to check 
for $@
         $dtype .= " ($dver)";
     };
     if ( $meta->{dbm_mldbm} )
@@ -180,9 +182,8 @@
         $dtype .= ' + MLDBM';
         eval {
             $dver = MLDBM->VERSION();
-            $dtype .= " ($dver)";
+            $dtype .= " ($dver)";    # (*)
         };
-        $dtype .= ' + ' . $meta->{dbm_mldbm};
         eval {
             my $ser_class = "MLDBM::Serializer::" . $meta->{dbm_mldbm};
             my $ser_mod   = $ser_class;
@@ -190,7 +191,8 @@
             $ser_mod .= ".pm";
             require $ser_mod;
             $dver = $ser_class->VERSION();
-            $dver and $dtype .= " ($dver)";
+            $dtype .= ' + ' . $ser_class;    # (*)
+            $dver and $dtype .= " ($dver)";  # (*)
         };
     }
     return sprintf( "%s using %s", $dbh->{dbm_version}, $dtype );

Modified: dbi/trunk/lib/DBD/File.pm
==============================================================================
--- dbi/trunk/lib/DBD/File.pm   (original)
+++ dbi/trunk/lib/DBD/File.pm   Sat Aug 28 04:07:38 2010
@@ -304,6 +304,8 @@
     my $dtype = "IO::File";
     eval {
        $dver = IO::File->VERSION ();
+
+       # when we're still alive here, everthing went ok - no need to check for 
$@
        $dtype .= " ($dver)";
        };