On Mon, Dec 03, 2001 at 07:07:33PM +0000, Jacqui Caren wrote: > On Mon, 3 Dec 2001 17:20:24 +0000, Tim Bunce wrote: > > > On Sat, Dec 01, 2001 at 01:19:47PM -0500, Thomas A.Lowery wrote: > > > This is a good idea. I'm wondering what other "Defaults" to allow for? > > > > The attribute should be named 'ado_...', the underscore is part of > > the driver-private name prefix. > > This is one reason why I said it should not be taken as-is :-) > > Another reason is my 'hack' feels like one. It just does not > feel like production code for some reason... > > before inclusion I welcome more experienced DBD developers to > provide thier feedback... Being as tired as I was I am pretty > sure I did something else wrong :-(
It's only a minor issue. My note was aimed at Tom before he patched it in. > > Beware of the performance cost of all these extra little attributes. > > It's a cost paid by all even if not used. > > Yes - however I *need* this one (somehow) as the alternative is some > major hacking of a *lot* of source code to work around the tatty > SqlServer ADO driver only - I hope :-) > > If it was rejected (and I was waiting for it!) I would have included an > ENV lookup or similar and would have had to support the 'hack' myself. > Not my preferred solution but if neede to get the job done... :-( Creating a subclass of the DBI might also work. [Sidebar: Here's something that someone on dbi-dev with time on their hands might want to look into: subclassing *drivers*. I.e. a user writes a DBD::MyOracle as a subclass of DBD::Oracle and then connects using "dbi:MyOracle:...". There's bound to be a few loose ends to sort out but the principle is sound. Probably.] Tim.