> From: Tim Bunce [mailto:[EMAIL PROTECTED]] > On Thu, Feb 07, 2002 at 11:13:22AM +0100, Steffen Goeldner wrote: [...] > > + sub sql_identifier_quote_char { > > + my $dbh = shift; > > + my $sth = $dbh->func('adSchemaDBInfoLiterals','OpenSchema'); > > + while ( my $row = $sth->fetch ) { > > + return $row->[1] if $row->[0] eq 'QUOTE'; # XXX > > + } > > + return undef; > > + } > > Probably need a $sth->finish in there.
No that is unneccessary! The DBI docs (version 1.201) state that $sth->finish "Indicates that no more data will be fetched from this statement handle before it is either executed again or destroyed." The $sth will be destroyed during the 'return' processing, so a $sth->finish should be quite superfluos here. -- Henrik Tougaard, Copenhagen, Denmark - an un'finish'ed, danish DBD::Ingres maintainer.
