Great. Thanks Jonathan. Tim.
On Thu, Feb 07, 2002 at 04:03:14PM -0800, Jonathan Leffler wrote: > On Thu, 7 Feb 2002, Tim Bunce wrote: > >On Thu, Feb 07, 2002 at 01:41:16PM -0800, Jonathan Leffler wrote: > >> It is by no means a show-stopper, but whenever I build DBI 1.21, it > >> always copies Changes down to blib/lib/DBI/Changes.pm instead of only > >> doing it once. [...] > >[...] But a patch would be handy :) > > Agreed; I didn't manage to work out the alternative before... > > Here's an embedded patch with, I think, the tabs fixed correctly after > cut'n'paste. If this does not work for you, then the attachment is the > direct output of 'diff -u Makefile.PL.old Makefile.PL' saved to file. > > --- Makefile.PL.old Wed Feb 6 19:15:46 2002 > +++ Makefile.PL Thu Feb 7 15:52:39 2002 > @@ -231,10 +231,15 @@ > DBI.c: Perl$(OBJ_EXT) > > # make Changes file available as installed pod docs "perldoc DBI::Changes" > -config :: $(INST_LIBDIR)' . $dir_sep . '.exists > - @$(MKPATH) $(INST_LIBDIR)/DBI > - @$(RM_F) $(INST_LIBDIR)/DBI/Changes.pm > - $(CP) Changes $(INST_LIBDIR)/DBI/Changes.pm > +inst_libdbi = $(INST_LIBDIR)' . $dir_sep . 'DBI > +changes_pm = $(inst_libdbi)' . $dir_sep . 'Changes.pm > + > +config :: $(changes_pm) > + > +$(changes_pm): Changes > + @$(MKPATH) $(inst_libdbi) > + @$(RM_F) $(changes_pm) > + $(CP) Changes $(changes_pm) > '; > > return $xst; > > Note that I've been a little more systematic in using $dir_sep > everywhere; the previous code used it in the dependency lines, but > not the action lines. I also invented a couple of make variables to > simplify life. This seems to work in a way that the other did not. > The Changes get copied down very early on in the build process, so > the mkpath operation is probably quite critical. > > Whether this is the best solution is entirely open to negotiation, > but it seems to work on Solaris 7 with GNU and Sun versions of make. > > And I don't think you need to release a DBI 1.22 or DBI 1.211 with > any urgency - at least, not just to fix this nit. > > >Is it a 'problem' in any way? > > Cosmetic. > > make > make test > make install > > Three times you copy Changes.pm into blib. With the patch, just the once. > > -- > Jonathan Leffler #include <disclaimer.h> > STSM, Informix Database Engineering, IBM Data Management Solutions > Phone: +1 650-926-6921 Tie-line: 630-6921 > Email: [EMAIL PROTECTED] ([EMAIL PROTECTED]) > Notes ID: Jonathan Leffler/Menlo Park/IBM@IBMUS > Guardian of DBD::Informix v1.00.PC1 -- http://dbi.perl.org > *=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=* > Please update your address book to use [EMAIL PROTECTED] because > [EMAIL PROTECTED] will not work starting 2002-07-01. Expect > slower responses because I can't use Lotus Notes as fast as Unix > email. One day, this signature will shrink! > --- Makefile.PL.old Wed Feb 6 19:15:46 2002 > +++ Makefile.PL Thu Feb 7 15:52:39 2002 > @@ -231,10 +231,15 @@ > DBI.c: Perl$(OBJ_EXT) > > # make Changes file available as installed pod docs "perldoc DBI::Changes" > -config :: $(INST_LIBDIR)' . $dir_sep . '.exists > - @$(MKPATH) $(INST_LIBDIR)/DBI > - @$(RM_F) $(INST_LIBDIR)/DBI/Changes.pm > - $(CP) Changes $(INST_LIBDIR)/DBI/Changes.pm > +inst_libdbi = $(INST_LIBDIR)' . $dir_sep . 'DBI > +changes_pm = $(inst_libdbi)' . $dir_sep . 'Changes.pm > + > +config :: $(changes_pm) > + > +$(changes_pm): Changes > + @$(MKPATH) $(inst_libdbi) > + @$(RM_F) $(changes_pm) > + $(CP) Changes $(changes_pm) > '; > > return $xst;
