Thanks. I;ve applied something like that. Let me know if it's okay for you.
Tim. On Mon, May 24, 2004 at 03:41:49PM -0400, Jeff Urlwin wrote: > This is having trouble getting through to [EMAIL PROTECTED] > > Jeff > > -----Original Message----- > From: Jeff Urlwin [mailto:[EMAIL PROTECTED] > Sent: Monday, May 24, 2004 11:19 AM > To: '[EMAIL PROTECTED]' > Subject: DBI Patch [SVN version] fix for t\10examp.t > > > Tim, > > As I discussed in my e-mails regarding DBI issues when I tried to build, the > following patch allows me to test and build successfully, with your > threading update in place. The second line change is not necessary to make > things pass, but it seems more reasonable to me to make the description > clear -- but it may not be. However the "ok($r, $r)" definitely causes me > issues and crashes the test severely. > > Index: t/10examp.t > =================================================================== > --- t/10examp.t (revision 359) > +++ t/10examp.t (working copy) > @@ -460,8 +460,8 @@ > > print "selectall_hashref\n"; > $r = $dbh->selectall_hashref($std_sql, 'NAME', undef, $dir); -ok($r, $r); > -ok(ref $r eq 'HASH', ref $r); > +ok($r, "selectall_hashref"); > +ok(ref $r eq 'HASH', "selectall_hashref is hash test: " . ref $r); > ok(keys %$r == $rows); > ok($r->{ $row_a[2] }{SIZE} eq $row_a[1], qq{$r->{ $row_a[2] }{SIZE} eq > $row_a[1]}); > > > > Regards, > > Jeff > >
