On Thu, Sep 30, 2004 at 10:29:25AM +0200, Steffen Goeldner wrote: > Tim Bunce wrote: > > >On Wed, Sep 22, 2004 at 03:52:09PM +0200, Steffen Goeldner wrote: > > > >>Compiling DBD::Oracle with Borland C++ 5.5, I have a bunch of warnings: > >> > [...] > >> > >>1. ignore the warnings :-( > >>2. suppress the warnings (-w-8065) > >>3. Force __STDC__=1 > >>4. Force C++ compile (-P): > > > > 5. Remove the #if/#else/#include ocik/#endif > > > >So you're just left with #include <ociapr.h> #include <ociap.h>
(Ignore me, I thought that logic was in dbdimp.h) > Or I add __BORLANDC__ to the #if. > I'm curious if Oracle would accept this patch ... You might spend half you're life waiting to find out, and then it'll only apply to Oracle 11 onwards :) > >I can live with assuming support for ANSI C style prototypes > >since we already effectively require perl 5.6 and that requires ANSI C. > > > >Would that work? (If so, patch welcome :) I'd be happy with option 4 or 3c. (There are a bunch of hacks in there already, so adding another wouldn't be too bad :-) > >>Would you accept these patches? As an example, the attached patch adds > >>the casts to dbdimp.c. > > > >They're useful anyway - applied. > > O.k., attached are the casts required by my compiler for oci8.c. > I'm not sure about the (imp_fbh_st*) cast - maybe this should be > (imp_fbh_t*)? Applied. Thanks. Tim.
