Matt Sergeant <[EMAIL PROTECTED]> writes: > On 6-Feb-06, at 5:10 PM, Tim Bunce wrote: > > > On Mon, Feb 06, 2006 at 05:53:18AM -0800, Gisle Aas wrote: > >> Tim Bunce <[EMAIL PROTECTED]> writes: > >> > >>> I agree. Any chance yould you patch lib/DBI/DBD.pm to add in a > >>> section > >>> describing what driver authors need to do? > >> > >> Is this enough? > > > > That's great. I tweaked it a bit and appended the body of it below. > > Let > > me know if I've said anything wrong. > > > > Driver authors please take note! > > Can I add that in conditionally based on the DBI version? > > e.g. > > #if (DBI_VERSION > 151) > #define PERL_NO_GET_CONTEXT > #endif
There isn't currently a DBI_VERSION to test against. DBIXS.h does define DBIXS_VERSION and this could have been incremented, but PERL_NO_GET_CONTEXT need to be defined before this file is included. If DBIXS_VERSION was moved to a different header file this could have been made to work: #include "DBIXS_VERS.h" #if DBIXS_VERSION >= 94 #define PERL_NO_GET_CONTEXT #endif #include "DBIXS.h" --Gisle
