On Wed, 2007-04-11 at 09:59 -0500, Scott T. Hildreth wrote:
> I had to add this to dbdimp.c, mysql_warning_count() is not implemented
> before 4.1,
>
> #if MYSQL_VERSION_ID >= SQL_STATE_VERSION
> imp_sth->warning_count = mysql_warning_count(&imp_dbh->mysql);
> #else
> imp_sth->warning_count = 0;
> #endif
>
>
Also :-),
These tests fail since the older clients don't support the features,
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/80procs.t 255 65280 32 44 11-32
t/multi_statement.t 255 65280 7 8 4-7
t/prepare_noerror.t 3 1 2
t/utf8.t 16 3 6 11-12
The tests need to check the version of the client as well as the server.
I'm not sure how you would do that.
> I don't know if setting the count to 0 is what I should do here.
>
>
> On Wed, 2007-03-28 at 13:01 -0500, Scott T. Hildreth wrote:
> > Feel free to send it to me before release, we will have the old client
> > on that server until we upgrade it. Which will be awhile.
> >
> >
> > On Tue, 2007-03-27 at 22:18 -0400, Patrick Galbraith wrote:
> > > Scott,
> > >
> > > Thanks! I need to somehow find a 4.0 binary for OS X to find these pesky
> > > things.
> > >
> > > regards,
> > >
> > > Patrick
> > >
> > > Scott T. Hildreth wrote:
> > >
> > > >Pat,
> > > >
> > > > The #ifdef's still need to be removed in the calls below.
> > > >
> > > >Thanks.
> > > >
> > > >dbdimp.c: In function `mysql_st_fetch':
> > > >dbdimp.c:3429: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c:3593: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c: In function `mysql_st_FETCH_internal':
> > > >dbdimp.c:3931: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c:3945: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c: In function `mysql_bind_ph':
> > > >dbdimp.c:4264: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c:4291: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c:4303: error: too few arguments to function `mysql_dr_error'
> > > >dbdimp.c: In function `mysql_db_reconnect':
> > > >dbdimp.c:4465: error: too few arguments to function `mysql_dr_error'
> > > >
> > > >On Sun, 2007-03-25 at 10:40 -0400, Patrick Galbraith wrote:
> > > >
> > > >
> > > >>Dear DBD::mysql users and developers,
> > > >>
> > > >>I'm pleased to announce the release of DBD::mysql 4.004! This release
> > > >>contains various fixes, per Changelog:
> > > >>
> > > >>* Work around a bug in old 3.23 servers by specifying NOT NULL for
> > > >>fields used
> > > >> as a primary key in tests. (Bug #20325, reported by Julian Ladisch)
> > > >>* Add support for mysql_warning_count statement handle attribute. (Bug
> > > >>#25457,
> > > >> patch from Philip Stoev)
> > > >>* Add support for mysql_multi_statements connection option. (RT #12322,
> > > >>based
> > > >> on patch from Doug Morris)
> > > >>* Had to bump to 4.003 do to print statement in mysql.pm that made it
> > > >> into the dist. Even though you can delete a file on CPAN, you cannot
> > > >> re-upload it if it's the same name. Mea Culpa.
> > > >>* UTF8-Flag not set with flag mysql_enable_utf8 and column collation
> > > >>utf8_bin patch,
> > > >> Joost Diepenmaat, (RT #24738)
> > > >>* Fixed do_error definition (Scott Hildreth, Tim Bunce)
> > > >>* Conversion of test suite to Test::More
> > > >>
> > > >>This release was possible due to the efforts of:
> > > >>
> > > >>Jim Winstead
> > > >>Tim Bunce
> > > >>Scott Hildreth
> > > >>Joost Diepenmaat
> > > >>Dave Rolsky
> > > >>Philip Stoev
> > > >>Doug Morris
> > > >>Julian Ladisch
> > > >>
> > > >>And the rest of the community, and anyone else I forgot to mention!
> > > >>
> > > >>Thank you for using DBD::mysql and MySQL!
> > > >>
> > > >>The files:
> > > >>
> > > >> file: $CPAN/authors/id/C/CA/CAPTTOFU/DBD-mysql-4.004.tar.gz
> > > >> size: 122247 bytes
> > > >> md5: ba89b04b003dec320c893f2553a98ede
> > > >>
> > > >>
> > > >>Also:
> > > >>
> > > >>http://search.cpan.org/~capttofu/DBD-mysql-4.004/
> > > >>
> > > >>Kind regards,
> > > >>
> > > >>Patrick Galbraith
> > > >>
> > > >>
> > > >>
> > > >>
> > >
> > >
--
Scott T. Hildreth <[EMAIL PROTECTED]>
