On Thu, 2008-02-14 at 10:03 -0600, Scott T. Hildreth wrote:
> not ok 9 - match char
> #   Failed test 'match char'
> #   at t/80ora_charset.t line 83.
> #          got: '?'
> #     expected: '  '
>                  /\
>                  ||
>                  a char I can't print, looks like a degree symbol :-)
> 
> not ok 10 - match char
> #   Failed test 'match char'
> #   at t/80ora_charset.t line 84.
> #          got: '?'
> 

This patch fixes test 9 & 10,

--- 80ora_charset.t.orig        2008-03-05 17:34:58.000000000 -0600
+++ 80ora_charset.t     2008-03-05 17:34:47.000000000 -0600
@@ -74,14 +74,14 @@
     if ($is_utf8) {
         ok(Encode::is_utf8($ch));
         ok(Encode::is_utf8($nch));
+
+        is($ch, "\xb0", "match char");
+        is($nch, "\xb0", "match char");
     }
     else {
         ok(!Encode::is_utf8($ch));
         ok(!Encode::is_utf8($nch));
     }
-
-    is($ch, "\xb0", "match char");
-    is($nch, "\xb0", "match char");
 }



> ok 11
> ok 12
> not ok 13 - match char
> #   Failed test 'match char'
> #   at t/80ora_charset.t line 83.
> #          got: '?'
> 
> not ok 14 - match char
> #   Failed test 'match char'
> #   at t/80ora_charset.t line 84.
> #          got: '?'


  These test assume that the database can use utf8, as far as I know the
database has to be created with a certain character set, i.e. utf8 for
it to handle utf8 data.  

> 
> ...I install the module anyways, since only 4 tests fail and 80ora_charset is 
> a 
>    new test in 1.20.  I would like to know why this fails.
> 
> 
> Thanks, 
>     STH

Reply via email to