On Fri, 27 Nov 2009 10:21:05 -0400, Ralph Doncaster <ralphdoncas...@gmail.com> wrote:
> It seems I can't post attachments to the list, so here's the patch inline: Looks sane to me, but I'm not the DBD::Oracle maintainer :) While you're at it, I'd like to see some more changes: * make /usr/share/oracle not hardcoded but variable * make Instant Client work on windows too (Windows instant client works fine with the current Makefile.PL if installed on C:\Oracle\instantclient_11_1, but it does NOT work at all when installed in C:\Program Files\Oracle\... due to the space (I tried yesterday with the newest Strawberry) > --- ../DBD-Oracle-1.23-3oaWaD/Makefile.PL 2009-04-29 10:04:24.000000000 > -0500 > +++ Makefile.PL 2009-11-23 16:18:31.000000000 -0600 > @@ -1055,14 +1055,19 @@ > 'proc/lib/proc.mk', > 'proc16/lib/proc16.mk', > ); > - my @mk_oci = ( > + my @mk_oci32 = ( > + 'rdbms/demo/demo_rdbms32.mk' > + ); > + my @mk_oci64 = ( > 'rdbms/demo/demo_xe.mk', > 'rdbms/lib/oracle.mk', > 'rdbms/demo/oracle.mk', > 'rdbms/demo/demo_rdbms.mk', > + 'rdbms/demo/demo_rdbms64.mk', > 'rdbms/lib/ins_rdbms.mk' #Oracle 11 full client for 64 bit and maybe 32 > bit?? > > ); > + my @mk_oci = perl_is_64bit() ? @mk_oci64 : @mk_oci32; > $client_version and push @mk_proc, # Oracle Instant Client > "/usr/share/oracle/$client_version/client/demo.mk", > "/usr/share/oracle/$client_version/client64/demo.mk"; -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
