On Thu, Dec 03, 2009 at 08:01:08PM +0000, Martin J. Evans wrote: > H.Merijn Brand wrote: > >> > >>> # Failed test 'result, non numeric cast to double (strict)' > >>> # at t/90sql_type_cast.t line 97. > >>> # got: '2' > >>> # expected: '0' > >> I'd expect those 2 at the moment as there is an outstanding issue with > >> Perl_sv_2nv. I left them in so if Tim had any time he could see them.
Sorry for the delay. I've been tied up with progressing some work on plperl http://www.mail-archive.com/pgsql-hack...@postgresql.org/msg140671.html http://www.mail-archive.com/pgsql-hack...@postgresql.org/msg140769.html I hope to get to this in the next few days. > >> I don't really know how/why each test is duplicated with different > >> prefixes in those below - I don't get that. > > Perhaps Tim can tell me how to fix that. The t/zv*_*.t tests are wrappers for the main tests. They're written by Makefile.PL. The t/zvg_* test look like: #!perl -w $ENV{DBI_AUTOPROXY} = 'dbi:Gofer:transport=null;policy=pedantic'; require './t/01basics.t'; # or warn $!; the t/zvg_* test look like: #!perl -w $ENV{DBI_PUREPERL} = 2; require './t/01basics.t'; # or warn $!; and the zvxgp_* test look like: #!perl -w $ENV{DBI_PUREPERL} = 2; $ENV{DBI_AUTOPROXY} = 'dbi:Gofer:transport=null;policy=pedantic'; require './t/01basics.t'; # or warn $!; This approach (of running the entire test suite with a pure-perl DBI, via gofer, and a pure-perl DBI via gofer) forces the DBI::PurePerl and gofer code to keep in sync. The zvg_ and zvxgp_ failures are pointing out that DBI::PurePerl needs updating. Tim.