On Fri, Mar 11, 2011 at 10:27:16PM +0000, Martin J. Evans wrote:
> On 11/03/2011 16:53, Tim Bunce wrote:
> >Time's in very short supply at the moment, but if someone can contribute
> >tests for these (ideally as patches to existing test scripts) then I'll
> >fix'em as soon as I get a moment.
> >
> >Both are simple:
> > https://rt.cpan.org/Public/Bug/Display.html?id=66127
> > https://rt.cpan.org/Public/Bug/Display.html?id=64330
> >
> >Tim.
> Attached a patch for ping issue. However:
>
> o wasn't sure where to put it 08keeperr.t seemed to have some logic
> o it raised another issue - ping on DBD::Sponge does not return true
> and DBD::Sponge does not have ping. I left the test in for that so
> it produces 2 errors not 1.
>
> Of course by the time it is re-run with those z* tests the errors mount up.
>
> I'll commit it if you want but because of above I haven't.
Yes, please do.
> If you give me a hint where the best place for the other bug is I'll
> try and do that too.
Umm. I hate to see the t/10examp.t getting any bigger (it really needs
breaking up) but just after the "check ShowErrorStatement ParamValues
are included and sorted" test seems like a good spot.
Just call execute(1,2); # not enough args
check that that returns an error
and the errstr values don't contain ParamValues
and that $sth->{ParamValues} is empty.
Thanks!
Tim.
