On Thu, Feb 16, 2012 at 02:42:32PM +0000, Martin J. Evans wrote: > On 16/02/12 12:46, Tim Bunce wrote: > >On Tue, Feb 14, 2012 at 02:06:30PM +0000, Martin J. Evans wrote: > >>Should we be updating dbipport.h before next release. > >> > >>I'll do it we think it should be done. I believe we have 3.19 and 3.20 is > >>available. > > > >Devel::PPPort is mainly about helping new extensions, or new code, > >written using the latest APIs to work with old perls. That doesn't > >really apply to us. The only significant new code is Dave's and he's > >already done the legwork to make it portable to old perls. > > > >Having said that, I've no objection to keeping dbipport.h up to date. > > > >Perhaps running the updated dbipport.h will turn up something we've missed. > >Driver authors should do likewise. > > > >Tim. > > I ran it on DBI files and all it suggested (ignoring adding ppport.h) was: > > Suggested changes: > --- DBI.xs > +++ DBI.xs.patched > @@ -1,3 +1,8 @@ > +#define NEED_grok_number > +#define NEED_grok_numeric_radix > +#define NEED_newRV_noinc > +#define NEED_sv_2pv_flags > > I also ran it on various DBD::ODBC files but nothing found. > > I'll update dbipport.h later today.
Please also apply the above. Might as well stay up to date. Thanks Martin. Tim.
