On Fri, Mar 02, 2012 at 03:11:17PM +0000, Tim Bunce wrote:
> On Fri, Feb 10, 2012 at 03:27:24PM +0000, Dave Mitchell wrote:
> I'm concerned that changing the API, and thus forcing all compiled
> drivers to be recompiled at the same time the DBI is installed,
> isn't worth the gain. Especially as drivers shouldn't be using DBIS in
> any hot code anyway.
> 
> However, I'd still like to make the change. So I'm thinking it might be
> best to support *both* mechanisms for at least a few releases before
> removing the old one. The gives end users a "safe zone" where they
> can upgrade the DBI and then later upgrade compiled drivers after
> they've been changed.
> 
> Would you be okay with reworking the change along those lines?

I'd be happy in principle, although some guidance would be welcome, as I'm
not currently clear what within my patch does (and doesn't) constitute an
API change.  Is it the addition of an extra XS function?

Is the fix as easy as something along the lines of

    #if DBIXS_REVISION > NNN
    #  define DBIS the-new-way
       ... and other stuff
    #else
    #  define DBIS the-old-way
       ... and other stuff
    #endif

???

-- 
Britain, Britain, Britain! Discovered by Sir Henry Britain in
sixteen-oh-ten. Sold to Germany a year later for a pfennig and the promise
of a kiss. Destroyed in eighteen thirty-forty two, and rebuilt a week
later by a man. This we know. Hello. But what of the people of Britain?
Who they? What do? And why?   -- "Little Britain"

Reply via email to