On Nov 9, 2012, at 4:13 AM, John Scoles <byter...@hotmail.com> wrote:
> Well I made that ping patch for DBIx::Connector a few months ago on one of my > production boxes with no impact but then again I am not doing anything fancy > (no rac raid etc). > > If it is critical to DBDx::Connector to ensure a query can be run then no, if > you are going for 100% work alike betweeen all DBDs then no again and I am > sure H.Merijn would like that. > > An option would be nice as well At this point, I'm inclined to leave it as is. Why? Because one of the advantages of DBIx::Connector is fixup mode. Use that mode, and ping will only be called by txn() and friends only in the event of a failure. Which means that its overhead goes away, for the most part, no matter how it's implemented. So yeah, it's slower, but use fixup mode and avoid it altogether. Best, David
