On Wed, 22 May 2013 19:47:13 +0200, Jens Rehsack <rehs...@gmail.com>
wrote:

> If you want to redo - fix
> 
> #   Failed test 'Record 3'
> #   at t/80_rt.t line 205.
> 
> before (prints out a lot - very lot - of ",")
> 
> Cheers

Not as bad as you make me believe :)

But what do we want here? Skip those tests is NANO is used?
SQL::Statement *is* a prereq, so basically, I don't care if
someone wants to limit the usage by restricting to that.

IMHO the fix is easy as in "Do not test 80_rt at all when under NANO
most of rt is edge cases (and some tests are dups from SQL::Statement
to verify fixes on that side)

With perl-5.18.0 (now my production perl on laptop):

DBD-CSV-git 516 > env DBI_SQL_NANO=1 prove -vwb t/80_rt.t
t/80_rt.t ..
ok 1 - RT-18477 - use of prepare/execute with placeholders fails
ok 2 - connect
ok 3 - prepare
ok 4 - execute
ok 5 - prepare
DBD::CSV::st execute failed: You passed 3 parameters where 1 required [for 
Statement "
        select SEGNO, OWNER, TYPE, NAMESPACE, EXPERIMENT, STREAM, UPDATED, SIZE
        from   rt18477
        where  NAMESPACE  =    ?
           and EXPERIMENT LIKE ?
           and STREAM     LIKE ?
           "] at t/80_rt.t line 42.
not ok 6 - execute

#   Failed test 'execute'
#   at t/80_rt.t line 42.
DBD::CSV::st fetch failed: Attempt to fetch row without a preceeding execute () 
call or from a non-SELECT statement [for Statement "
        select SEGNO, OWNER, TYPE, NAMESPACE, EXPERIMENT, STREAM, UPDATED, SIZE
        from   rt18477
        where  NAMESPACE  =    ?
           and EXPERIMENT LIKE ?
           and STREAM     LIKE ?
           "] at t/80_rt.t line 43.
not ok 7 - fetch

#   Failed test 'fetch'
#   at t/80_rt.t line 43.
not ok 8 - content

#   Failed test 'content'
#   at t/80_rt.t line 44.
#     Structures begin differing at:
#          $got = undef
#     $expected = ARRAY(0x87e6cb0)
ok 9 - finish
ok 10 - drop table
ok 11 - disconnect
ok 12 - RT-20550 - Using "Primary key" leads to error
ok 13 - connect
ok 14 - prepare
ok 15 - drop table
ok 16 - disconnect
ok 17 - RT-33764 - $! is not an indicator of failure
ok 18 - connect
ok 19 - prepare
ok 20 - execute
ok 21 - error message
ok 22 - fetch
ok 23 - error message
ok 24 - finish
ok 25 - drop table
ok 26 - disconnect
ok 27 - RT-43010 - treatment of nulls scrambles joins
ok 28 - connect
ok 29 - table def
ok 30 - create table
ok 31 - table def
ok 32 - create table
ok 33 - insert 1
ok 34 - insert 2
DBD::CSV::db selectrow_hashref failed: Couldn't find WHERE clause in ' JOIN   
rt43010_1 USING  (id)' at 
/pro/lib/perl5/site_perl/5.18.0/i686-linux-64int-ld/DBI/DBD/SqlEngine.pm line 
333.
 [for Statement "SELECT * FROM   rt43010_0 JOIN   rt43010_1 USING  (id)"] at 
t/80_rt.t line 113.
not ok 35 - join 1 2

#   Failed test 'join 1 2'
#   at t/80_rt.t line 113.
not ok 36 - content

#   Failed test 'content'
#   at t/80_rt.t line 119.
#     Structures begin differing at:
#          $got = undef
#     $expected = HASH(0x913aab8)
ok 37 - drop table
ok 38 - drop table
ok 39 - disconnect
ok 40 - RT-44583 - DBD::CSV cannot read CSV files with dots on the first line
ok 41 - connect
ok 42 - prepare
ok 43 - execute
ok 44 - field names
ok 45 - prepare
ok 46 - execute
ok 47 - fetch
ok 48 - content
ok 49 - finish
ok 50 - connect
ok 51 - prepare
ok 52 - field names
ok 53 - finish
ok 54 - drop table
ok 55 - disconnect
ok 56 - RT-46627 - DBD::File is damaged now
ok 57 - connect
ok 58 - create
ok 59 - prepare ins
ok 60 - insert 1
ok 61 - insert 2
ok 62 - finish
ok 63 - insert 3
ok 64 - prepare upd
Out of memory!
# Tests were run but no plan was declared and done_testing() was not seen.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 5/64 subtests

Test Summary Report
-------------------
t/80_rt.t (Wstat: 256 Tests: 64 Failed: 5)
  Failed tests:  6-8, 35-36
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=1, Tests=64, 10 wallclock secs ( 0.02 usr  0.01 sys +  7.58 cusr  1.06 
csys =  8.67 CPU)
Result: FAIL


-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.17   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

Reply via email to