On Mon, 18 Sep 2017 11:19:08 +0200, "H.Merijn Brand"
<h.m.br...@xs4all.nl> wrote:

> Makefile.PL states MIN_PERL_VERSION => '5.008', so I am still in the
> supported range.
> 
> My cause for digging is
> 
> Tie-Hash-DBD-0.16:
> - x86_64-linux-ld / 5.8.8:
>   - FAIL
> http://www.cpantesters.org/cpan/report/b06ed2c0-9b4b-11e7-b9b4-ee532540c4eb
> 
> When I wanted to make sure it is not already fixed by module
> updatesperl5.8.8 Makefile.PL
> 
> (and my requirements are too low), I noticed

This is fixed by updating Storable, so the minimum requirement for
Storable's version is too low (or in our case, not required at all)

-- showing just stable perl versions and Storable version updates ...

$ corelist -a Storable
  v5.8.0     2.04
  v5.8.1     2.08
  v5.8.3     2.09
  v5.8.4     2.12
  v5.8.5     2.13
  v5.8.8     2.15
  v5.8.9     2.19
  v5.10.0    2.18
  v5.10.1    2.20
  v5.12.0    2.22
  v5.14.0    2.27
  v5.16.0    2.34
  v5.18.0    2.41
  v5.20.0    2.49
  v5.22.0    2.53
  v5.26.0    2.62

Working from there ...

perl-5.8.8 with Storable 2.15 failed
perl-5.8.8 with Storable 2.51 passes
perl-5.8.9 with Storable 2.19 passes

So I'd suggest to make Storable version 2.19 a minimal requirement:

--8<---
diff --git a/Makefile.PL b/Makefile.PL
index 4a58334..ee11d00 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -76,6 +76,7 @@ my %opts = (
        },
     },
     PREREQ_PM => {
+         'Storable' => 2.16,
          ( $^O eq 'MSWin32' ? ( 'File::Spec' => 3.31, ) : () ),
     },
     CONFLICTS => {
-->8---

Agree?

Reading Storable changelog, that makes sense, as the failing tests
involved dclone:

--8<---
Sat Mar 31 06:11:06 IST 2007   Abhijit Menon-Sen <a...@toroid.org>

    Version 2.16

        1. Fixes to Storable::dclone, read_magic, retrieve_lscalar
        2. Storable 0.1 compatibility
        3. Miscellaneous compile/leak/test/portability fixes
-->8---

> $ perl5.8.8 Makefile.PL
> :
> :
> $ make
> :
> :
> $ make test
> :
> t/06attrs.t ..................... 1/?
> #   Failed test 'Can set sth NAME'
> #   at t/06attrs.t line 263.
> 
> #   Failed test 'Can set sth NAME_lc'
> #   at t/06attrs.t line 263.
> 
> #   Failed test 'Can set sth NAME_uc'
> #   at t/06attrs.t line 263.
> 
> #   Failed test 'Can set sth NAME_hash'
> #   at t/06attrs.t line 263.
> 
> #   Failed test 'Can set sth NAME_lc_hash'
> #   at t/06attrs.t line 263.
> 
> #   Failed test 'Can set sth NAME_uc_hash'
> #   at t/06attrs.t line 263.
> # Looks like you failed 6 tests of 163.
> t/06attrs.t ..................... Dubious, test returned 6 (wstat 1536, 0x600)
> Failed 6/163 subtests


-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.27   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

Attachment: pgpkclnMvqWfM.pgp
Description: OpenPGP digital signature

Reply via email to