On Mon, Aug 15, 2005 at 11:47:18AM +0100, Charles Jardine wrote:
> 
> BTW. Can you help me with two related queries to do with
> $dbh->do()
> 
>  1. Why is it that, in DBD::Oracle, dbd_db_do is #defined in
>     dbdimp.h and provided with a prototype in Oracle.h when
>     there is no implementation? Is this a historical vestige?
>     I ask because the prototype suggests the same problem
>     with the utf8 flag.

Historical vestige. Please include removing these lines in your patch:
Oracle.h:int     dbd_db_do _((SV *sv, char *statement));
dbdimp.h:#define dbd_db_do              ora_db_do

>  2. Should you make a similar change to the code after
>     '#ifdef dbd_db_do4' in Driver.xst? I know that DBD::Oracle
>    does not use this code, but any driver which does will have
>    the same problem.

Yes. Make it #if defined(dbd_db_do4) || defined(dbd_db_do4_sv)
Thanks!

Tim.

Reply via email to