>
> I think it's your honours to put the patch together, if you're willing to.
>
I was afraid you might say that.
Suggested patch attached, against svn revision 3821.
Regards,
--
Jon
Index: DBIx/Class.pm
===================================================================
--- DBIx/Class.pm (revision 3821)
+++ DBIx/Class.pm (working copy)
@@ -5,6 +5,7 @@
use vars qw($VERSION);
use base qw/DBIx::Class::Componentised Class::Accessor::Grouped/;
+use DBIx::Class::StartupCheck;
sub mk_classdata {
@@ -233,6 +234,8 @@
jnapiorkowski: John Napiorkowski <[EMAIL PROTECTED]>
+jon: Jon Schutz <[EMAIL PROTECTED]>
+
jshirley: J. Shirley <[EMAIL PROTECTED]>
konobi: Scott McWhirter
Index: DBIx/Class/StartupCheck.pm
===================================================================
--- DBIx/Class/StartupCheck.pm (revision 0)
+++ DBIx/Class/StartupCheck.pm (revision 0)
@@ -0,0 +1,70 @@
+package DBIx::Class::StartupCheck;
+
+BEGIN {
+
+ { package TestRHBug; use overload bool => sub { 0 } }
+
+ sub _has_bug_34925 {
+ my %thing;
+ my $r1 = \%thing;
+ my $r2 = \%thing;
+ bless $r1 => 'TestRHBug';
+ return !!$r2;
+ }
+
+ sub _possibly_has_bad_overload_performance {
+ return $] < 5.008009 && ! _has_bug_34925();
+ }
+
+ unless ($ENV{DBIC_NO_WARN_BAD_PERL}) {
+ if (_possibly_has_bad_overload_performance()) {
+ print STDERR "\n\nWARNING: " . __PACKAGE__ . ": This version of Perl is likely to exhibit\n" .
+ "extremely slow performance for certain critical operations.\n" .
+ "Please consider recompiling Perl. For more information, see\n" .
+ "https://bugzilla.redhat.com/show_bug.cgi?id=196836 and/or\n" .
+ "http://lists.scsys.co.uk/pipermail/dbix-class/2007-October/005119.html.\n"; .
+ "You can suppress this message by setting DBIC_NO_WARN_BAD_PERL=1 in your\n" .
+ "environment.\n\n";
+ }
+ }
+}
+
+=head1 NAME
+
+DBIx::Class::StartupCheck - Run environment checks on startup
+
+=head1 SYNOPSIS
+
+ use DBIx::Class::StartupCheck;
+
+=head1 DESCRIPTION
+
+Currently this module checks for, and if necessary issues a warning for, a
+particular bug found on RedHat systems from perl-5.8.8-10 and up. Other checks
+may be added from time to time.
+
+Any checks herein can be disabled by setting an appropriate environment
+variable. If your system suffers from a particular bug, you will get a warning
+message on startup sent to STDERR, explaining what to do about it and how to
+suppress the message. If you don't see any messages, you have nothing to worry
+about.
+
+=head1 CONTRIBUTORS
+
+Nigel Metheringham
+
+Brandon Black
+
+Matt S. Trout
+
+=head1 AUTHOR
+
+Jon Schutz
+
+=head1 LICENSE
+
+You may distribute this code under the same terms as Perl itself.
+
+=cut
+
+1;
Index: DBIx/Class/Manual/Intro.pod
===================================================================
--- DBIx/Class/Manual/Intro.pod (revision 3821)
+++ DBIx/Class/Manual/Intro.pod (working copy)
@@ -373,6 +373,16 @@
For a complete overview of the available attributes, see
L<DBIx::Class::ResultSet/ATTRIBUTES>.
+=head1 NOTES
+
+=head2 Problems on RHEL5/CentOS5
+
+There is a problem with slow performance of certain DBIx::Class operations in
+perl-5.8.8-10 and later on RedHat and related systems, due to a bad backport of
+a "use overload" related bug. The problem is in the Perl binary itself, not in
+DBIx::Class. If your system has this problem, you will see a warning on
+startup, with some options as to what to do about it.
+
=head1 SEE ALSO
=over 4
_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/[EMAIL PROTECTED]
