Hi,

nice component. Some thoughts:

It seems like you do not handle an update of a row. Is this what you want? I don't like the underscore :) I'd prefer "-" as delimiter. You could add a config option where you can specify which character you want. Two underscores in a row look not pretty nice. You could add =~ s/__/_/ g to remove them. You could also add a test which checks whether the gernerated token is already there. "Catalyst Book, Volume 1" and "Catalyst-Book, Volume 1" would have the same token!

Nice anyway :)

cheers,

moritz


Am 30.04.2008 um 22:36 schrieb J. Shirley:

Hey all,

I wrote a trivial module that helps with related row inserts after a
transformation to go from a field like, "Catalyst Book, Volume 1" to
"catalyst_book__volume_1" (default behavior).  It's ready to hit CPAN,
but wanted to solicit input before uploading it.  It doesn't do much
at the moment, but figure it can grow.  The ->tokenize method is what
does the transformation, and that can be overridden very easily to
perform more advanced changes.

http://dev.catalystframework.org/repos/bast/DBIx-Class-Tokenize/0.01/trunk

Thanks,
-Jay

_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/[EMAIL PROTECTED]


_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/[EMAIL PROTECTED]

Reply via email to