The attached patches fix a couple of test failures I'm seeing in 0.08/trunk.
1. 03podcoverage.t: DBIx::Class::Storage::DBI::Role::QueryCounter has a naked subroutine `meta`. I believe that comes from Moose, and therefore need not be documented, so the patch merely ignores that sub. 2. 68inflate_has_a.t uses DBIx::Class::CDBICompat::Relationships, which does a `use Clone`; but Clone isn't a dependency in Makefile.PL. I'm assuming that DBIx::Class itself isn't expected to depend on Clone, so I've added a test_requires for it. If you'd like me to re-test and/or re-generate these patches with a different branch, please let me know. -- Aaron Crane ** http://aaroncrane.co.uk/
Index: t/03podcoverage.t =================================================================== --- t/03podcoverage.t (revision 4387) +++ t/03podcoverage.t (working copy) @@ -101,6 +101,11 @@ # must kill authors. 'DBIx::Class::Storage::DBI::Replicated' => { skip => 1 }, + +# skip meta because it comes from Moose + 'DBIx::Class::Storage::DBI::Role::QueryCounter' => { + ignore => [qw(meta)] + }, }; foreach my $module (@modules) {
Index: Makefile.PL =================================================================== --- Makefile.PL (revision 4387) +++ Makefile.PL (working copy) @@ -34,6 +34,10 @@ test_requires 'Test::NoWarnings' => 0.08; test_requires 'Test::Exception' => 0; +# It's actually DBIx::Class::CDBICompat::Relationships that needs this, but +# t/68inflate_has_a.t tests that component +test_requires 'Clone' => 0; + install_script 'script/dbicadmin'; tests "t/*.t t/*/*.t";
_______________________________________________ List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ Searchable Archive: http://www.grokbase.com/group/[EMAIL PROTECTED]