On Tue, 2009-05-05 at 10:57 +0200, Matthias Zeichmann wrote: > in your patch you have: > -------->8------------------------------------ > +#use constant ORA_BLOB => 113; ## ORA_CLOB is 112 > -------->8------------------------------------ > in lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm > > is it intentional that the line is commented out ?
I was reluctant to pull in DBD::Oracle for :ora_types at first, so was just going to use constants. After looking at some of the other drivers and seeing explicit DBD::* usage, I relented. So, in short: yes, it's intended to be commented out. It's mere detritus now, unless rephrased as an instructional comment atop the DBD::Oracle use. I'll do so. Thanks! _______________________________________________ List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ Searchable Archive: http://www.grokbase.com/group/[email protected]
