On Tue, Mar 9, 2010 at 11:23 PM, Pedro Melo <[email protected]> wrote:

> It was client work, I don't have access to the code anymore. But it
> looks good. See below for two improvements.
>    # Make sure we have options
>    # If we want to force cascade_* stuff
>    my $options = $rest[3] ||= {};
>

Thanks -- all of my classes already had the hash so assumed it was always
passed.



>     for ( qw/ cascade_delete cascade_copy / ) {
>         # Any user-defined value wins
>        $options->{$_} = 0 unless exists $options->{$_};
>     }
>

I figured I only needed to set it to zero if $options->{$_} was true, but I
guess it's supposed to be zero, not just false.

Thanks for the tips,





-- 
Bill Moseley
[email protected]
_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/[email protected]

Reply via email to