On Wed, Jan 09, 2013 at 01:50:09PM -0500, Phillip Moore wrote: > OK, I have verified that master passes the entire test suite with and > without defining DBICTEST_SYBASE_(DSN|USER|PASS). The only > difference is that I get a couple of warnings:
This is a problem. It means that our test somehow bypasses one of the codepaths. I will have to read more in depth a bit later to see why is this happening. In the meantime - let me know if this solves your problem: diff --git a/lib/DBIx/Class/Storage/DBI/Sybase/ASE.pm b/lib/DBIx/Class/Storage/DBI/Sybase/ASE.pm index 346dcd9..a41807e 100644 --- a/lib/DBIx/Class/Storage/DBI/Sybase/ASE.pm +++ b/lib/DBIx/Class/Storage/DBI/Sybase/ASE.pm @@ -277,7 +277,7 @@ sub _prep_for_execute { my ($sql, $bind) = $self->next::method (@_); if (my $identity_col = $self->_perform_autoinc_retrieval) { - $sql .= "\n" . $self->_fetch_identity_sql($ident, $identity_col) + $sql .= ";\n" . $self->_fetch_identity_sql($ident, $identity_col) } return ($sql, $bind); _______________________________________________ List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk