On Sun, Sep 14, 2008 at 11:52 PM, Pascal Craponne <[EMAIL PROTECTED]> wrote:
> Yes, you're right. I think that we can discard only nullable <-> > non-nullable conversions, and keep all others, until someone needs better :)I > just committed the "smart converter". > Changes work perfect ^_^ > Now, I need to understand what make a join to be "outer". > It seems easy to do it in RegisterAssociation method adding a "OR lefttable.column=NULL", doesn't it? I'm afraid that the worst problems will be in the CutOutOperands stage and/or the QueryRunner methods If you need a second point of view you know what to do! Regards. > > On Sun, Sep 14, 2008 at 23:48, Pablo Iñigo Blasco <[EMAIL PROTECTED]>wrote: > >> >> >> On Sun, Sep 14, 2008 at 11:29 PM, Pascal Craponne <[EMAIL PROTECTED]>wrote: >> >>> Removing the conversion may cause problems (If I remember correctly, >>> Expressions were not consistent, and we had exceptions). >>> >> >> I agree with you. If you remove the converts you get an exception on: >> >> ExpressionDipsatcher.Registrar.cs >> Line 255: var referenceExpression = Expression.Equal(thisKey, >> otherKey); >> >> Nonetheless it had been considered and test results are fine. >> IMO, given that such equal expression is only used for the join condition >> between two tables, convert expression should never exist in any operand. >> >> >>> I'm currently working in a different way: the conversion is emitted in >>> SQL only when necessary. >> >> >> Shouldn't it depend to the specific Vendor? How to decide when a convert >> is necessary? >> >> Regards. >> >> >> > > > -- > Pascal. > > jabber/gtalk: [EMAIL PROTECTED] > msn: [EMAIL PROTECTED] > > > > > -- Saludos. Pablo Iñigo Blasco . --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
