I leaved the old method commented out just in case the typo was intentional...
Well... I've yet seen such strange coder behaviour... I'm removing now... Giacomo On Mon, Jun 1, 2009 at 7:58 PM, Jonathan Pryor <[email protected]> wrote: > That probably is a typo, considering that ExpressionDispatcher is an > internal type. > > I do find it rather odd that fixing a typo would fix 5 unit tests. WTF > were those tests testing (i.e. which tests did this fix)? > > Doubly odd is that ExpressionDispatcher.Analyzer.cs contains two > AnalyzeTimeSpanMemberAccess(Expression, > MemberInfo) methods, one of which is private and commented out. Would you > mind removing the commented out version (as it's obviously no longer > needed)? > > Thanks, > - Jon > > > On Thu, 2009-05-28 at 12:02 +0200, Giacomo Tesio wrote: > > Another strange piece of code that I've fixed is related to timespan. > > I've found a correctly working (protected) > ExpressionDispatcher.AnalyzeTimeSpa*m*MemberAccess() member and a not > implemented (private) ExpressionDispatcher.AnalyzeTimeSpa*n*MemberAccess() > thowing NotImplementedException. > > This is so strange that I'm wondering if it was an error or not. > > BTW, changing the m to n made more than 5 unit tests to pass. > > > Giacomo > > On Tue, May 26, 2009 at 10:23 PM, Giacomo Tesio <[email protected]> wrote: > > I'm to commit (tomorrow) a big patch fixing 21 unit tests. > > I've only tested on SqlServer so I suggest to search for regressions on the > other vendors. > > One fix is related to wrong data not reling on the microsoft northwind db: > there's no Pen in the Northwind products' table (at least in the current > version I downloaded from microsoft) and the first product listed has > ProductName == 'Chai'. > > Since some tests would actually pass with correct data, I've corrected > this. > > This will break all tests reling to Pen and not having Chai. But I think we > should actually find a solution to this problem. > > > May be we could write a program that would use the different DbLinq's test > DLL to copy data from the Northwind sqlserver db to the others > (SqlLite,PostgreSQL etc...) > > But I haven't the time now to write it (I've to fix some other DbLinq bugs > on SqlServer, before) > > > Giacomo > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
