On Mon, 2009-06-15 at 20:26 +0300, Andrus Moor wrote: > I created patch for this. > OK to commit ?
Not yet, something else is needed first: Tests. One of two things needs to be done first: 1. Find an existing unit test which is failing, and which is fixed by this patch. Please mention which test is fixed. - or - 2. Write new unit tests, and include them in the patch. Furthermore, you need to ensure that no tests are regressed after applying this change (which is easier to do now that the SQLite, SQL Server, and L2SQL tests are no longer full of failures). You'll need to run the Release tests (as Debug tests include failing tests). On another note, there seems to be something wrong with the patch -- it contains lots of "=3D" characters. Perhaps it's a limitation of my mail client, but it makes reviewing the patch more difficult. - Jon --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
