Fixed those tests.
ReadTest_Math.Log01 still fail to me, due to the localization problem that Jon pointed. I can't fix it now, sorry... (and btw, this could be a quite complex fix...) Giacomo On Wed, Jun 24, 2009 at 9:35 AM, Giacomo Tesio <[email protected]> wrote: > Given that I can not invest too much time today on DbLinq, I'll try to take > a look about these failures. > > As to L2SQL, I think we should identify the reason for the fails since it > could show us an our bug. > If not, if we work better than L2SQL we should show this on the tests... > > > Giacomo > > > On Wed, Jun 24, 2009 at 6:02 AM, Jonathan Pryor <[email protected]> wrote: > >> >> Tonight on IRC: >> >> 18:02 < Shamar> but I've some failing tests on DbLinqTest.DataContextTest: >> 18:02 < Shamar> 1) Connection >> 18:03 < Shamar> 2) Ctor_ConnectionString_ExtraParameters_Munging >> 18:03 < Shamar> 3) Ctor_FileOrServerOrConnectionIsFilename >> 18:04 < Shamar> 4) Ctor_FileOrServerOrConnectionIsServer >> >> After some debugging, and I'm assuming that >> DbLinq.SqlServer_test_ndb_strict.dll was the culprit. This has been >> fixed in r1198. >> >> However, there are some additional failures. >> >> DbLinq.SqlServer_test.dll and DbLinq.SqlServer_test_strict.dll have a >> number of failures, and all of the L2SQL failures are due to the >> additional Employee partial definition in NorthwindCustom.cs: >> >> partial class Employee >> { >> [Column(Storage = "_EmployeeID", Name = "EmployeeID", DbType = "Int >> NOT NULL IDENTITY", IsDbGenerated = true)] >> public string Identifier >> { >> get { return this._EmployeeID.ToString(); } >> } >> } >> >> Remove this definition, and L2SQL passes. (The failures are *really* >> weird, many about generic type constraint violations.) Most of the >> DbLinq.SqlServer_test.dll tests also pass. >> >> Giacomo: Can you think of another way to test this behavior that doesn't >> result in L2SQL errors? (Apparently my "brilliant" idea of making this >> part of the normal Northwind type wasn't quite so brilliant after >> all...) >> >> After making that (uncommitted) change, only two are left: >> Test_NUnit_MsSql.ReadTests_DateTimeFunctions.DateTimeDiffTotalDaysSelectWithNulls01() >> and >> Test_NUnit_MsSql.ReadTests_DateTimeFunctions.DateTimeDiffTotalDaysSelectWithNulls02() >> both fail with an IndexOutOfRangeException. >> >> The cause? QueryRunner.Upsert() is trying to read the output variables >> of the INSERT SQL expression, and it thinks that there are two output >> variables (while there is actually only one), so it does >> 'dataReader.GetValue(outputParameterIndex)' on an invalid index. >> >> Oops. >> >> Anyone know what changed this behavior (and is able to fix it)? >> >> Thanks, >> - Jon >> >> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
