Jonathan Pryor riprovò: > > > This does not cleanly apply against DataContext.cs in trunk (r1218). > > > > Mh, perhaps a CR/LF problem? > > This appears to be part of it, as your patch had Unix (\n) line endings > while my DataContext.cs has DOS (\r\n) line endings. > > I find this rather strange, as the DataContext.cs file has no subversion > properties enabling platform line endings (whatever that setting is; > DataContext.cs has no svn properties at all). Furthermore, my svn > checkout was done from (and remains on) Linux (using svn 1.5.4), and I > really doubt that svn on Windows would change DOS line endings to Unix > line endings...
I'm on linux too, so I'd exclude that. :D > How are you checking out the source? > > How are you creating patches, for that matter? (The new diff *still* > doesn't apply against my checkout using patch, even with 'patch -l'.) 'patch -l' will ignore whitespaces, but it seems that line endings are not treated differently. I've created the first patches with 'git format-patch', while the latter has been done with 'svn diff'. > That said, it does pass all the unit tests, so feel free to commit (but > verifying that was more work than I would have thought). I'd just like > to know why your patch isn't usable... The patch I've generated on my harddisk seems correct, as it has CR/LFs in the body and the header has only unix style line endings, so I fear the problem is due to email clients and I suspect Evolution is converting the file while attaching. If this is the case converting with unix2dos should be sufficient. Unfortunately I can't do much to work around Evolution, other than gzipping patches to preserve their content. :/ Thank you for your patience, it's my first project with DOS line endings. :D -- Emanuele Aina Studio Associato Di Nunzio e Di Gregorio http://dndg.it/ Via Maria Vittoria, 2 10123 Torino - Italy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
