Hi,
Leif Jackson wrote:
Attached is the new patch with the slight change I figured for now the
easiest was to just move the FreeConfig for the smtpItems to the end of
freeall:, well maybe we want to think about a struct for these items that
can be global instead of the listnodes, *shrug* let me know.
I'm kind of wondering if we should add this to 2.0. On the one hand, it
sounds like something we can really use. On the other hand, it is not
just a fix, but more of a refactoring of the code, which I intend to
delay until after the 2.0 release.
Thanks,
Leif
p.s. I belive after a lopng bout of checks with valgrind ( an amazing
package for many reasons) that the memory leaks if any are only in the
main function of pop3, as far as I can tell imapd is clean! :)
OK... so we need to check POP3 for memleaks.
p.p.s. I have started on server side sorting code, may have something by
this weekend I can share. has ISCS thought about or started any similar
code before I get to far into it? thx.
We have not started any server side sorting code (IMAP SORT & THREAD)
yet. So please go ahead. Please mind that this code will not go into
2.0. If it ready soon it will go into 2.1. Sorry for that, but we really
need to stop adding features to 2.0 and just get it to work. We'll move
on after that.
Ilja
All,
I found one ting this breaks I will send a patch shortly.. Bascialy
bounce.c uses the config as a global. I don't see that this is a great
idea? I will be moving:
field_t dbmail_from_address, sendmail, postmaster;
to be global instead, so I can still FreeConfig in the main function.
Thanks,
Leif
Cool,
Ilja, I have attached a patch that adds a FreeConfig function, this
doesn't solve my memory leaks from list.c addnode, but makes it a lot
easier to debug as it free's the config list's right after their used
instead of at the end of the main (). Please commit it to cvs if you
feel
it warrants it.
Thanks,
leif
I've put the patch in CVS, because we'll need it anyway. This way, it's
also easier to debug it, because a simple cvs update will get everybody
the new code :)
The delivery chain is still buggy: When delivering messages through
LMTP, all messages get delivered twice.
Ilja
Leif Jackson wrote:
Ilja & Aaron,
I am looking for this patch. I cannot access it from sourceforge? Or
do
I
have to checkout from cvs differently than the default dbmail root? I
would be glad to look at this.... Also Aaron, i was working on your
sieve
code but there are some issues between the current libsieve you have
in
cvs and the last one posed on sourceforge, the api and the lib doesn't
match quite right or at least not to the code you have in the dbmail
cvs
tree, i am really exited about this feature and would like to help.
Thanks,
Leif
