Aaron Stone wrote:
The sizes returned through the msgsize, rfcsize, headerrfcsize, etc. variables
should all have been zero.
I constructed a message with a header, but without a body. So the header
size and other sizes are not zero. Only the message body was empty.
[EMAIL PROTECTED]:~/sandbox/dbmail$ telnet localhost 25
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
220 test01.office.fastxs.net ESMTP Postfix (Debian/GNU)
HELO example.com
250 test01.office.fastxs.net
MAIL FROM:<[EMAIL PROTECTED]>
250 Ok
RCPT TO:<[EMAIL PROTECTED]>
250 Ok
DATA
354 End data with <CR><LF>.<CR><LF>
Subject:
.
250 Ok: queued as 249AD19F30A
This had the possibility of going wrong when the buffers were not set to
zero
So there's also a problem of assuming a non-binary,
null terminated message. Aren't now email programs encouraged to support
binary data nowadays?
I have no clue actually.. :/
Aaron
Ilja Booij <[EMAIL PROTECTED]> said:
Hi all,
We've found a small error in insert_message_temp() in pipe.c.
The buffers strblock and tmpline were not initialised with '\0'
characters. Because of this, sending emails with an empty body resulted
in the message body possibly being filled with random characters (or
worse, characters from a previous message). This happened because the
strblock buffer was immidiately read from when the message body was empty.
A simple memset() did the trick.
I wonder if we have more of those possibly uninitialised buffers lying
around. :/
Ilja
_______________________________________________
Dbmail-dev mailing list
[email protected]
http://twister.fastxs.net/mailman/listinfo/dbmail-dev
