Paul J Stevens wrote:
You're probably correct here. Resource allocation/deallocation is still mostly unexplored territory for me. I've tried to be really carefull in leaving all cleanup actions in place, even though moving most of them to a separate imap_cleanup function. Some leaks are still there, but exposing them was part of my motivation for writing that patch. Looks to me like adding some calls to imap_cleanup here and there in ImapClientHandler should do the trick.
I've committed the ci_write() patch (for lack of a better name..) and added some more ci_cleanup() calls in the appropriate places. It seems to work OK here. I don't have any memleaks here in my test runs (using valgrind to spot mem-leaks and other memory errors)
Paul, can you test it on your machines? Ilja
