Here's a suspect line possibly responsible for the binary chars in messageblks.

in db.c,db_insert_message_block_physmessage line 856:

        escaped_query = (char *) my_malloc(sizeof(char) * maxesclen);

I don't see a:

        memset(escaped_query,'\0',sizeof(char) * maxesclen);

around.


Paul J Stevens wrote:

Reading header.c I noticed a likely bug.

read_header is supposed zero in case of errors, right? If so, attached patch should probably apply.



------------------------------------------------------------------------

Index: header.c
===================================================================
RCS file: /cvsroot-dbmail/dbmail/header.c,v
retrieving revision 1.6
diff -u -r1.6 header.c
--- header.c    2004/03/19 16:27:38     1.6
+++ header.c    2004/04/02 12:44:18
@@ -108,7 +108,7 @@
                        my_free(tmpline);
                        /* NOTA BENE: Make sure that the caller knows to free
                         * the header block even if there's been an error! */
-                       return -1;
+                       return 0;
                }
/* The end of the header could be \n\n, \r\n\r\n,


------------------------------------------------------------------------

_______________________________________________
Dbmail-dev mailing list
[email protected]
http://twister.fastxs.net/mailman/listinfo/dbmail-dev

--
  ________________________________________________________________
  Paul Stevens                                  mailto:[EMAIL PROTECTED]
  NET FACILITIES GROUP                     PGP: finger [EMAIL PROTECTED]
  The Netherlands________________________________http://www.nfg.nl

Reply via email to