Anton Nekhoroshih <[EMAIL PROTECTED]> said:

> 
> Hi
> 
> i changed db_get_message and db_put_message to
> char *db_get_message_contents(u64_t id, u64_t *len);
> int db_put_message_contents(u64_t id,const char *msg, u64_t len);
> and remove some ifdef ORACLE for sql queries
> needed add this function to dbmysql.c and dbpgsql.c
> then the driver of a database will be more universal

I'm a huge fan of returning int's as status codes and using arguments to pass
any pointers going into or coming out of a function. Note that in these
prototypes, the length is just as important as the string and so having them
on opposite sides of the function call is, IMHO, confusing.

Aaron

> 
> needded check on mysql and pgsql in some query
> "AND unique_id != ''" change to "unique_id is not null"
> then we can finally clean ifdef ORACLE
> 
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> 



-- 



Reply via email to