Thomas Mueller wrote:
Hi Aaron,
Wait, scratch that one moment, there was one thing I was worried about, INBOX.
In db.c and in imapcommand.c, there are a couple of str[n?]casecmp's with
"INBOX" and "inbox" as the parameters.
Thomas, try using your patch and creating a mailbox called "Inbox" and "inbox"
and see what happens. Does it fail? Does it show the same contents as "INBOX"
does it explode DBMail badly?
I prefer not to explode dbmail that's why I checked the code where
something happens with the INBOX :-)
I only found 3 lines of code that are relevant:
<snip code>
If we leave everything as it is only INBOX is allowed, if we remove line
716 and use strcmp with INBOX for the others we allow INBOX and
mailboxes like Inbox.
I did a quick test: I inserted 'inbox' into the database. Evolution now
shows 'INBOX' and 'inbox' where 'inbox' has the content of 'INBOX'. If I
delete a mail in one box it's deleted in the other one too. New messages
are always inserted into mailbox_idnr of INBOX.
I have missed a case insensitive comparison but I can't find it at the
moment :-(
So, to conclude, correct me if I'm wrong, we do not need to change
anything, except for the create_tables scripts, when we want to
following behaviour:
* Case INsensitivity for "INBOX". "Inbox", "inbox", "InBoX" are all
equivalent.
* Case sensitivity for all other mailboxes names.
Correct?
If this is true, I can change it in a whim.
Ilja
