Niblett, David A wrote:
> Paul,
> 
> Just a clarification please.  The first item (strcasecmp) that's
> completely correct, and I'll fix that.  Though one question.  I
> notice that all my users are not always "subscribed" to their
> INBOX, but Email can be delivered to them.  Does it hurt anything
> if the user is not subscribed to their INBOX, or should they be
> subscribed to it?

Subscription is *not* a requirement for delivery. That's why I think the error
checking on db_subscribe should be removed. Failure to subscribe may well
indicate some database error, but it doesn't indicate any kind of delivery 
failure.

This also seems to create a lot of confusion in valid_folder: Why have the
db_findmailbox_by_regex search for subscribed folders only?

Automatic subcription like you said earlier would seem like good policy, but it
should not affect the mechanism in question; assuming we want this functionality
for both pipe and network delivery, CREATE_FOLDERS should only affect network
(lmtp) delivery. And even then, automatic subscription should always occur on
automatic folder creation, but never if the folder exists already. (yo admin, I
keep trying to unsubscribe from my spam folder, but something keeps subscribing
me...)

> 
> On the second item, I'm a bit lost.  Yes I agree the naming could
> be better.  I think what you are requesting, is to move the valid_folder
> checking in LMTP to after the:
> 
> if (dsnuser_resolve(&dsnuser) != 0) ....
> 
> That would make sense.  If you are asking me to wait until all the
> RCPT names are entered then I'm a bit lost where that would go in the
> code.
> 

Probably right after lmtp.c:577
                        /* A successfully found recipient goes onto the list.
                         * The struct will be free'd from lmtp_reset(). */
                        list_nodeadd(&rcpt, &dsnuser,
                                     sizeof(deliver_to_user_t));

atleast then we know for sure dsnuser.userids will contain a list of valid
userids. For each of these userids something like valid_folder will have to be
called, and dsnuser.mailbox will need to be set if a matching mailbox already
exists.

> David,
> 
> I've been looking at your latest patch.
> 
> I see two problems: one minor, one major:
> 1. in sort/sort.c you're doing something like 
>   if (mailbox != "INBOX")
>   that don't compute in C. Use strncasecmp here please.
> 
> 2. valid_folder(const char *userid, char *folder)
> 
> the first argument is supposed to be a userid, but in lmtp.c you're
> passing a destination address, instead of a userid. the
> remove_folder/valid_folder logic should be handled *after*
> dsnuser_resolve, and then for each valid entry in the dsnuser.userids
> list.
> 
> Perhaps valid_folder should look like
> 
>   valid_folder(const deliver_to_user_t *dsnusers, char *folder)
> 
> and create the new folder (if necessary and allowed) for each of the
> recipients.
> 
> Bug History
> Date Modified  Username       Field                    Change
> 
> ======================================================================
> 23-Jul-04 23:37maXXmaster     New Bug
> 
> 24-Jul-04 03:38danweber       Bugnote Added: 0000110
> 
> 24-Jul-04 03:38danweber       Priority                 normal => high
> 
> 24-Jul-04 03:38danweber       Status                   new => confirmed
> 
> 24-Jul-04 17:05aaron          Bugnote Added: 0000111
> 
> 25-Jul-04 20:40maXXmaster     Bugnote Added: 0000112
> 
> 25-Jul-04 20:40maXXmaster     Bugnote Edited: 0000112
> 
> 25-Jul-04 20:44aaron          Bugnote Added: 0000113
> 
> 25-Jul-04 22:56maXXmaster     Bugnote Added: 0000114
> 
> 26-Jul-04 11:51maXXmaster     Bugnote Added: 0000115
> 
> 26-Jul-04 11:52maXXmaster     Bugnote Edited: 0000115
> 
> 26-Jul-04 13:00maXXmaster     Bugnote Added: 0000116
> 
> 26-Jul-04 16:15aaron          Bugnote Added: 0000117
> 
> 26-Jul-04 16:49maXXmaster     Bugnote Added: 0000118
> 
> 26-Jul-04 18:15aaron          Bugnote Added: 0000119
> 
> 26-Jul-04 18:22aaron          Bugnote Added: 0000120
> 
> 26-Jul-04 21:47maXXmaster     Bugnote Added: 0000121
> 
> 27-Jul-04 10:24aaron          Bugnote Added: 0000122
> 
> 27-Jul-04 10:28aaron          Bugnote Added: 0000123
> 
> 01-Aug-04 09:42maXXmaster     Bugnote Added: 0000127
> 
> 04-Aug-04 16:26ilja           Bugnote Added: 0000138
> 
> 05-Aug-04 07:56aaron          Bugnote Added: 0000144
> 
> 05-Aug-04 07:56aaron          Assigned To               => aaron
> 
> 05-Aug-04 07:56aaron          Resolution               open => fixed
> 
> 05-Aug-04 07:56aaron          Status                   confirmed =>
> resolved
> 05-Aug-04 16:00ilja           Status                   resolved =>
> closed  
> 05-Aug-04 22:34maXXmaster     Bugnote Added: 0000150
> 
> 05-Aug-04 22:34maXXmaster     Resolution               fixed => reopened
> 
> 05-Aug-04 22:34maXXmaster     Status                   closed =>
> feedback  
> 06-Aug-04 01:29aaron          Bugnote Added: 0000151
> 
> 06-Aug-04 10:28ilja           Bugnote Added: 0000152
> 
> 06-Aug-04 10:29ilja           Bug Monitored: ilja
> 
> 06-Aug-04 18:03aaron          Bugnote Added: 0000153
> 
> 07-Aug-04 07:14maXXmaster     Bugnote Added: 0000154
> 
> 08-Aug-04 06:59aaron          Bugnote Added: 0000155
> 
> 08-Aug-04 13:17maXXmaster     Bugnote Added: 0000156
> 
> 12-Aug-04 11:58aaron          Bugnote Added: 0000157
> 
> 12-Aug-04 11:58aaron          Status                   feedback =>
> acknowledged
> 19-Aug-04 11:39ilja           Priority                 high => normal
> 
> 25-Aug-04 17:43danweber       Bugnote Added: 0000206
> 
> 06-Dec-04 15:10niblettda      Bugnote Added: 0000424
> 
> 06-Dec-04 15:10niblettda      Bug Monitored: niblettda
> 
> 06-Dec-04 15:11niblettda      Bugnote Edited: 0000424
> 
> 06-Dec-04 15:13niblettda      Bugnote Edited: 0000424
> 
> 07-Dec-04 01:14aaron          Bugnote Added: 0000427
> 
> 07-Dec-04 19:05niblettda      File Added: dbmail-spam.patch
> 
> 07-Dec-04 19:30niblettda      Bugnote Added: 0000432
> 
> 07-Dec-04 19:32niblettda      Bugnote Edited: 0000432
> 
> 21-Dec-04 15:16niblettda      File Added: dbmail-folders.patch
> 
> 21-Dec-04 15:29niblettda      Bugnote Added: 0000457
> 
> 03-Feb-05 19:01Wolfram        Bugnote Added: 0000576
> 
> 18-May-05 16:46niblettda      Bugnote Added: 0000704
> 
> 18-May-05 16:46niblettda      File Added: dbmail-2.0.4-folders.patch
> 
> 20-May-05 18:33niblettda      Bugnote Added: 0000708
> 
> 20-May-05 18:34niblettda      File Added: dbmail-2.0.4_0.2-folders.patch
> 
> 20-May-05 18:35niblettda      Bugnote Edited: 0000708
> 
> 20-May-05 22:29Wolfram        Bugnote Added: 0000709
> 
> 20-May-05 22:51Wolfram        Bugnote Edited: 0000709
> 
> 20-May-05 23:52aaron          Bugnote Added: 0000710
> 
> 23-May-05 14:02niblettda      Bugnote Added: 0000711
> 
> 02-Aug-05 22:02niblettda      File Added: dbmail-2.0.4_0.4-folders.patch
> 
> 02-Aug-05 22:03niblettda      Bugnote Added: 0000795
> 
> 02-Aug-05 22:04niblettda      Bugnote Edited: 0000795
> 
> 02-Aug-05 22:19niblettda      File Added: dbmail-2.0.4_0.5-folders.patch
> 
> 02-Aug-05 22:20niblettda      Bugnote Added: 0000796
> 
> 09-Aug-05 15:41paul           Bugnote Added: 0000814
> 
> ======================================================================
> 


-- 
  ________________________________________________________________
  Paul Stevens                                  mailto:[EMAIL PROTECTED]
  NET FACILITIES GROUP                     PGP: finger [EMAIL PROTECTED]
  The Netherlands________________________________http://www.nfg.nl

Reply via email to