Eugene Prokopiev wrote:
> Paul J Stevens wrote:
> 
>> Ok, so if you do that, what happens if the new tables are not in place?
> 
> 
> The best way to resolve this problem is another configuration parameter
> for filtering turned off by default. This may be useful for perfomance
> reasons. But in this case DBMail must not confuse about absent parameter
> in configuration file. Is this behaviour possible?

Not necessary. You only need to handle db errors in db_get_mailbox_from_filters
gracefully: defaulting to mailbox=NULL, which you already do. I'd have to test
this, but I don't see any problems here. Perhaps remove or downgrade the trace
call after calling db_query.

> 
>> Only change I would suggest is calling db_get_mailbox_from_filters from
>> within sort_and_deliver.
> 
> 
> It's sensible.
> 
> 
> Need I change my patch or you will make this changes?

Please do. I can make time to do it, but it's your patch.

> Do you have plans to place my patch to dbmail.org into download area or
> within dbmail source archive in separate file?

I'll include them first as dpatch file in debian/patches/02_simple_filters or
something like that.


-- 
  ________________________________________________________________
  Paul Stevens                                  mailto:[EMAIL PROTECTED]
  NET FACILITIES GROUP                     PGP: finger [EMAIL PROTECTED]
  The Netherlands________________________________http://www.nfg.nl

Reply via email to