Anton,

Most of the changes look like valid cleanups to me, however I have a
couple of issues.

Did you try to compile with all modules and unit-testing enabled? Sqlite
is broken by the patch.

Also, this is invalid:

@@ -1647,12 +1645,17 @@ int db_icheck_isheader(GList  **lost)
        char query[DEF_QUERYSIZE];
        memset(query,0,DEF_QUERYSIZE);

-       snprintf(query, DEF_QUERYSIZE,
+/*     snprintf(query, DEF_QUERYSIZE,
                        "SELECT MIN(messageblk_idnr),MAX(is_header) "
                        "FROM %smessageblks "
                        "GROUP BY physmessage_id HAVING MAX(is_header)=0",
+                       DBPFX);*/
+       snprintf(query, DEF_QUERYSIZE,
+                       "SELECT messageblk_idnr "
+                       "FROM %smessageblks "
+                       "WHERE is_header=0 AND "
+                       "physmessage_id NOT IN (SELECT physmessage_id
FROM dbmail_messageblks WHERE is_header=1)",
                        DBPFX);


That query is designed to find header blocks that are not marked as
such. This change will break that.

What is that #pragma directive in dbmail.h? It's causing a lot of warnings.

Finally, I'm unable to compile with the patch applied

dbmail.h:1176: warning: ignoring #pragma warning
/bin/bash ./libtool --tag=CC --mode=link gcc  -Wall -O1 -g
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gmime-2.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -W -Wall -Wpointer-arith
-Wstrict-prototypes  -lcrypt -lglib-2.0   -Wl,--export-dynamic
-lgmodule-2.0 -ldl -lglib-2.0   -lgmime-2.0 -lz -lnsl -lgobject-2.0
-lglib-2.0   -o check_dbmail_auth  check_dbmail_auth.o libdbmail.la -lcheck
gcc -Wall -O1 -g -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gmime-2.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -W -Wall -Wpointer-arith -Wstrict-prototypes
-Wl,--export-dynamic -o check_dbmail_auth check_dbmail_auth.o
./.libs/libdbmail.a -lresolv
/home/paul/git/dbmail-2.2/modules/.libs/libsqlite.a
/usr/lib/libsqlite3.so
/home/paul/git/dbmail-2.2/modules/.libs/libsort_sieve.a
/usr/lib/libsieve.so
/home/paul/git/dbmail-2.2/modules/.libs/libauth_sql.a
/usr/lib/libgmime-2.0.so /usr/lib/libgmodule-2.0.so -ldl
/usr/lib/libgthread-2.0.so -lpthread -lrt -lz -lnsl
/usr/lib/libgobject-2.0.so /usr/lib/libglib-2.0.so -lcrypt -lcheck
./.libs/libdbmail.a(libdbmail_la-serverparent.o):(.data+0x0): multiple
definition of `configFile'
check_dbmail_auth.o:(.data+0x0): first defined here



Anton Zakatov wrote:
> Hello!
> The goals of this patch :
> 1. Move external declaration to header files.
> 2. Set proper printf format strings.
> 3. Speedup lmtp daemon by cache header_dict between messages.
> 4. Fix problem with incorrect Content-Type header, that changed by gmime
> after add any headers (such as Return-Path and others). Thanks Jeffrey
> Stedfast.
> 5. Set proper logical order of charset transformation. Use internal
> base64 encoder for subject in envelope to avoid gmime header encode bug
> (multiple encoding charsets in gmime < 2.2.6?).
> 6. Return utf-8 encoded headers to libsieve.
> 
> 
> With best regards, Anton Zakatov.  E-mail: [EMAIL PROTECTED]
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Dbmail-dev mailing list
> [email protected]
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev


-- 
  ________________________________________________________________
  Paul Stevens                                      paul at nfg.nl
  NET FACILITIES GROUP                     GPG/PGP: 1024D/11F8CD31
  The Netherlands________________________________http://www.nfg.nl
_______________________________________________
Dbmail-dev mailing list
[email protected]
http://twister.fastxs.net/mailman/listinfo/dbmail-dev

Reply via email to