Aaron Stone wrote: >> #define NFLAGS 5 >> >> int msgflags[NFLAGS]; >> memset(msgflags,0,NFLAGS*sizeof(int)); > > Was I staring at the code but using the wrong constant?
Nono, just to make my point that: int someval[SIZE]; memset(someval,0,SIZE); would be incorrect, but memset(someval,0,SIZE*sizeof(int)); would be correct. > >> or maybe even better (per convention in several gnu manpages): >> >> memset(msgflags,0,sizeof(msgflags)); > > Sure, that's fine. I'll stick to this one then. Seems less prone to misunderstanding. > >>> Paul, should dbmail-message.c: dbmail_construct_message call map_headers >>> just as dbmail_message_init_with_string and >>> dbmail_message_init_with_stream do? >> That is a matter of consistency, and only relevant for people who are >> using libdbmail to brew their own tools. Afaik, dbmail_construct_message >> is currently used only to send messages out, *not* store them or do >> anything that requires access to the message's headers. > > pipe.c: send_alert does. Ah. _______________________________________________ Dbmail-dev mailing list [email protected] http://twister.fastxs.net/mailman/listinfo/dbmail-dev
