On 15-nov-2006, at 17:13, Paul J Stevens wrote:

Leander Koornneef wrote:

4) debian init-script failes to reload dbmail-timsieved

fixed.

it seems this was not fixed (using the dbmail.2.2.1-1 debian package).

Changing $SIEVE_NAME to dbmail-timsieve introduces a new bug,
because $SIEVE_NAME is used to contruct the argument to
--pidfile: /var/run/dbmail/dbmail-timsieve.pid, but dbmail-timsieved
creates pidfile /var/run/dbmail/dbmail-timsieved.pid

I found a better fix for the original bug, which is actually caused by
a bug in start-stop-daemon:

start-stop-daemon --name <process-name> does not account for
the 15 character truncation of <process-name> in /proc/<pid>/stat
which is imposed by the kernel, so it will never find any processes
with the name "dbmail-timsieved", because that has 16 characters
in it. See also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=353015

For now, removing the "--name ${_name}" argument in the reload
function seems to work fine as a workaround.

I also discovered another (sort-of) bug in the init-script:

Setting START_<NAME>=false in /etc/default/dbmail does
not prevent the daemons from being started, because the
test [ "false" ] evaluates to true in (ba)sh :-)
I've changed dbmail.init to also accept false instead of commenting
them out for disabling the daemons.

The attached patch fixes both these issues.

Leander

Attachment: dbmail.diff
Description: Binary data

Reply via email to