On 2013-08-20 16:31, Paul J Stevens wrote:
On 08/20/2013 02:16 PM, Thomas Raschbacher wrote:

It lists version 0.9.9 ?

The version is from mutils/mhash_config.h

For FreeBSD I include the config.h a second time to get round this.

Nice trick. I'll do that as well.

Maybe someone should tell mutils folks that it might not be the best
idea to export VERSION
in a library header? (I mean they could just use MHASH_VERSION)

Mhash is dead, as in un-maintained and abandoned. I think you should
take it up with the packager. For Debian it was fixed in-distro a long
time ago.

that doesn't sound good. isn't there some alternative then?

Apart from that I think it would be best maybe to not use VERSION but
rather change the name to DBMAIL_VERSION, since that would also prevent
this problem occuring again at some later point when another library
header exports this again. (I don't know how easy it is to change
configure stuff to use DBMAIL_VERSION instead of VERSION, so you could
just #define DBMAIL_VERSION VERSION right after the include to make it
simple)

Sounds like a good idea.
yeah I do think personally that would be the best choice for the future too ;)

Or would it be ok/better to just include config.h *last* of all includes ?

Whatever works.

@Paul:
Do you intend to put one of those choices into the next release? Because if you do I will just ignore this for now since it doesn't really do much harm except confuse an admin /user maybe ;)

Regards
_______________________________________________
DBmail mailing list
[email protected]
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail

Reply via email to