Re: [PATCH 01/14] Big kfree NULL check cleanup - net

[YOSHIFUJI Hideaki / 吉藤英明]

In article <[EMAIL PROTECTED]> (at Thu, 13 Oct 2005 21:25:43 +0200), Jesper 
Juhl <[EMAIL PROTECTED]> says:

> --- linux-2.6.14-rc4-orig/net/ipv4/netfilter/ip_nat_snmp_basic.c      
> 2005-10-11 22:41:33.000000000 +0200
> +++ linux-2.6.14-rc4/net/ipv4/netfilter/ip_nat_snmp_basic.c   2005-10-13 
> 11:31:09.000000000 +0200
> @@ -1161,8 +1161,7 @@ static int snmp_parse_mangle(unsigned ch
>               
>               if (!snmp_object_decode(&ctx, obj)) {
>                       if (*obj) {
> -                             if ((*obj)->id)
> -                                     kfree((*obj)->id);
> +                             kfree((*obj)->id);
>                               kfree(*obj);
>                       }       
>                       kfree(obj);

Maybe:
    if (*obj)
        kfree((*obj)->id);
    kfree(obj);

Otherwise;
Acked-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html