From: Andrea Bittau <[EMAIL PROTECTED]>
Subject: Re: service code bug in linux & tcpdump
Date: Tue, 24 Jan 2006 11:37:15 +0000
Message-ID: <[EMAIL PROTECTED]>
> On Tue, Jan 24, 2006 at 08:22:56PM +0900, Yoshifumi Nishida wrote:
> > I believe applications should do htonl(), like port number.
>
> did tcpdump get it wrong then?
> print-dccp.c:315
>
> (void)printf("request (service=%d) ", dhr->dccph_req_service);
>
> should that be EXTRACT_32BITS(&dhr->dccph_req_service) ?
In my opinion, yes.
Thanks,
--
Yoshifumi Nishida
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
