Hi Arnaldo,
many thanks for the detailed feedback - that has taught me some things I did
not know.
I will reshape the patch with regards to comments. While at it, would like
to increase resolution up to units of 100ms, with a default value of 10
corresponding to the TCP RTO value - as per earlier email by Mark Handley.
| - "r_sample=%uus\n", dccp_role(sk), sk,
| + "r_sample=%us\n", dccp_role(sk), sk,
|
| wrong, as r_sample is in microseconds, it comes from a timeval_delta,
| that gets it from dccp_timestamp and the elapsed times, originally in
| tenths of microsoeconds but multiplied by 10 to get back to
| microseconds.
Disagree with the above, since r_sample is not changed and t_elapsed is
converted from units of 10*microseconds to microsecond by multiplication:
r_sample = timeval_delta(&now, &packet->dccphtx_tstamp);
t_elapsed = dp->dccps_options_received.dccpor_elapsed_time * 10;
I will put that into a different patch, as I am just going over previous ones
that I have sent and checking each one of them.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
