On 12/8/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: In-line ccid3_hc_tx_insert_options
The function ccid3_hc_tx_insert_options currently only does a no-op,
since the operation
DCCP_SKB_CB(skb)->dccpd_ccval = hctx->ccid3hctx_last_win_count;
is already performed _unconditionally_ in ccid3_hc_tx_send_packet.
This redundancy is removed and the remaining stub function inlined.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Gerrit,
A couple of points here:
- the whole ccid3_hc_tx_insert_options could actually be removed with
a little work as there is no ccid2 equivalent and so the whole thing
isn't needed! If you want I can tidy that one up or up to you.
- don't inline functions - at the moment people are saying let gcc
decide when to do it - see comments in linus' git tree recently.
Ian
--
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
